D21202: Added basic JavaScript functions to support animated PDF

Anthony Fieroni noreply at phabricator.kde.org
Thu May 16 06:54:16 BST 2019


anthonyfieroni added inline comments.

INLINE COMMENTS

> kjs_display.cpp:19
> +
> +static KJSPrototype *g_displayProto;
> +

use unique_ptr

> kjs_display.cpp:35-38
> +    static bool initialized = false;
> +    if ( initialized )
> +        return;
> +    initialized = true;

if (g_displayProto)
      return;

> kjs_display.cpp:40
> +
> +    g_displayProto = new KJSPrototype();
> +

g_displayProto.reset(new KJSPrototype);

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21202

To: joaonetto, aacid, #okular
Cc: anthonyfieroni, sander, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190516/bb8d3a0b/attachment.html>


More information about the Okular-devel mailing list