[okular] [Bug 407326] Move Continuous view option from View menu to View Mode submenu, to make the main toolbar more useful.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=407326

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|REPORTED                    |CONFIRMED
                 CC|                            |nate at kde.org

--- Comment #2 from Nate Graham <nate at kde.org> ---
I'm looking into this, and that's the rub. Adding "Continuous" into the submenu
is pretty trivial:

diff --git a/ui/pageview.cpp b/ui/pageview.cpp
index 59f9565e5..9a5028789 100644
--- a/ui/pageview.cpp
+++ b/ui/pageview.cpp
@@ -587,6 +587,8 @@ do { \
     ac->addAction(QStringLiteral("view_continuous"), d->aViewContinuous );
     connect( d->aViewContinuous, &QAction::toggled, this,
&PageView::slotContinuousToggled );
     d->aViewContinuous->setChecked( Okular::Settings::viewContinuous() );
+    d->aViewMode->addSeparator();
+    d->aViewMode->addAction( d->aViewContinuous );

     // Mouse mode actions for viewer mode
     d->mouseModeActionGroup = new QActionGroup( this );


Making sure it doesn't appear in the submenu when the submenu is in the menubar
is trickier. If you have a patch ready, feel free to submit it with [RFC] in
the title, making it clear in the description that you're asking for
assistance.

-- 
You are receiving this mail because:
You are the assignee for the bug.