D20760: Okular Annotation: add support for line ending style for Straight Line tool

Rajeesh K Nambiar noreply at phabricator.kde.org
Thu May 9 09:53:49 BST 2019


knambiar added a comment.


  In D20760#462808 <https://phabricator.kde.org/D20760#462808>, @tobiasdeiminger wrote:
  
  > There's another problem we haven't discussed yet: Line endings work only if you have poppler >= 0.72 installed, else they will be silently ignored. Version 0.72 is quite recent, a lot of people won't have it because their distro ships an older version. Should we try to handle this? If yes, how? We can use cmake to detect poppler version, but I don't see an easy way to propagate the information from generator to UI at runtime.
  
  
  Indeed.
  There's a few `#ifdef HAVE_POPPLER_mm_nn` checks in the code, may be we could adapt it for 0.72?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D20760

To: knambiar, #okular, #vdg, sander, ngraham
Cc: aacid, pino, sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190509/c1b7f7b0/attachment.html>


More information about the Okular-devel mailing list