D19123: Added option to search for whole words only

Joao Oliveira noreply at phabricator.kde.org
Thu May 2 18:36:03 BST 2019


joaonetto marked an inline comment as done.
joaonetto added inline comments.

INLINE COMMENTS

> aacid wrote in page.h:192
> Both functions need to have proper documentation. And the new one needs a since marker (same for all the other "public" functions) in core/*.h you added/changed
> 
> And the "to be merged" should be marked with a TODO so maybe we see it when we decided to break BC

Done the TODO part.
Is this documentation all right? 
If not, can you explain what should I be looking for defining?

> aacid wrote in textpage.cpp:875
> Make this const
> Are we sure this is never going to be 0? I had a look at the strignLengthAdapatedWithHyphens and i'm not 100% sure :D

Only if the tiny text entity is "-\n", I made it to see to make sure.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D19123

To: joaonetto, #okular, aacid
Cc: davidhurka, yurchor, aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190502/6392c562/attachment.html>


More information about the Okular-devel mailing list