D19123: Added option to search for whole words only

[Albert Astals Cid]

aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.


  Something needs fixing
  
    ==27223== Conditional jump or move depends on uninitialised value(s)
    ==27223==    at 0xFA1013F: Okular::TextPagePrivate::findTextInternalForward(int, QString const&, bool (*)(QStringRef const&, QStringRef const&), QList<TinyTextEntity*>::const_iterator const&, int, QList<TinyTextEntity*>::const_iterator const&, bool) (textpage.cpp:993)
    ==27223==    by 0xFA0F53A: Okular::TextPage::findText(int, QString const&, Okular::SearchDirection, Qt::CaseSensitivity, Okular::RegularAreaRect const*, bool) (textpage.cpp:768)
    ==27223==    by 0xF9F5FD3: Okular::Page::findText(int, QString const&, Okular::SearchDirection, Qt::CaseSensitivity, Okular::RegularAreaRect const*, bool) const (page.cpp:310)
    ==27223==    by 0xF9A87F3: Okular::DocumentPrivate::doContinueDirectionMatchSearch(void*) (document.cpp:1673)
    ==27223==    by 0xF9BF4E9: Okular::Document::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (moc_document.cpp:370)
    ==27223==    by 0x643A101: QObject::event(QEvent*) (in /usr/lib/libQt5Core.so.5.12.2)
    ==27223==    by 0x5632E23: QApplicationPrivate::notify_helper(QObject*, QEvent*) (in /usr/lib/libQt5Widgets.so.5.12.2)
    ==27223==    by 0x563A5F0: QApplication::notify(QObject*, QEvent*) (in /usr/lib/libQt5Widgets.so.5.12.2)
    ==27223==    by 0x640EDF8: QCoreApplication::notifyInternal2(QObject*, QEvent*) (in /usr/lib/libQt5Core.so.5.12.2)
    ==27223==    by 0x6411EE7: QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (in /usr/lib/libQt5Core.so.5.12.2)
    ==27223==    by 0x64656C3: ??? (in /usr/lib/libQt5Core.so.5.12.2)
    ==27223==    by 0x81937BE: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.6000.0)
  
  This is valgrind tell us there's something uninitalized being used, what i did to get this
  
  valgrind okular
  open file
  Press Ctrl+F
  type something on the search bar
  
  the "find whole words" was not checked because that's the state it originally was on starting okular.
  
  Can you please try to fix this?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D19123

To: joaonetto, #okular, aacid
Cc: davidhurka, yurchor, aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190331/51ad4938/attachment.html>