D19539: Replace some iterator loops by range-based for

Albert Astals Cid noreply at phabricator.kde.org
Wed Mar 6 18:40:53 GMT 2019


aacid added inline comments.

INLINE COMMENTS

> pageview.cpp:941
>  {
> -    QVector< PageViewItem * >::const_iterator it = d->items.constBegin(), itEnd = d->items.constEnd();
> -    for ( ; it < itEnd; ++it )
> +    for ( PageViewItem * item : d->items )
>      {

This code is suddenly less performant than the old one.

Read https://doc.qt.io/qt-5/qtglobal.html#qAsConst

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D19539

To: sander, #okular
Cc: aacid, davidhurka, okular-devel, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190306/fef0930f/attachment.html>


More information about the Okular-devel mailing list