D19539: Replace some iterator loops by range-based for

[Albert Astals Cid]

aacid added a comment.


  auto makes the code much more unreadable for me, i don't want to have to go to the header to figure out which type the variable is

INLINE COMMENTS

> presentationwidget.cpp:313
>      // delete frames
> -    QVector< PresentationFrame * >::iterator fIt = m_frames.begin(), fEnd = m_frames.end();
> -    for ( ; fIt != fEnd; ++fIt )
> -        delete *fIt;
> +    for ( const auto& frame : m_frames )
> +        delete frame;

qDeleteAll

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D19539

To: sander, #okular
Cc: aacid, davidhurka, okular-devel, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190305/5d7be2f5/attachment-0001.html>