D19123: [WIP]Added option to search for whole words only

Joao Oliveira noreply at phabricator.kde.org
Sat Mar 2 12:43:17 GMT 2019


joaonetto added a comment.


  In D19123#423152 <https://phabricator.kde.org/D19123#423152>, @davidhurka wrote:
  
  > In D19123#414714 <https://phabricator.kde.org/D19123#414714>, @joaonetto wrote:
  >
  > > This works properly for most cases, but still, it has some limitations.
  > >  If searching for r on a text, and the text contains R$, the R will be found.
  > >  Every word that has a space behind and a symbol after, or a symbol before and space after, or symbol before and after, will be found.
  > >  I guess that's a good trade-off, but we can work to improve it, if wanted.
  >
  >
  > This sounds optimal to me, not like a trade-off. Or how could it be improved?
  >
  > By requiring whitespace on both sides, `BAUD` would not find `USART0.BAUD`, and `argv` would not find `char *argv[]`.
  
  
  Well, in this version of the patch it would, since I'm checking if the char before/after is letter or number. Searching for argv or BAUD would return a result.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D19123

To: joaonetto, #okular
Cc: davidhurka, yurchor, aacid, ngraham, okular-devel, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190302/d1a0bbbb/attachment.html>


More information about the Okular-devel mailing list