D18658: Modify search bar in the contextDrawer

Carl Schwan noreply at phabricator.kde.org
Fri Mar 1 13:32:06 GMT 2019


ognarb added inline comments.

INLINE COMMENTS

> aacid wrote in CMakeLists.txt:12
> I don't like this.
> 
> If you need a new kirigami or something make a vesion check and then enable kirigami only if X verison is available, but i don't like the general requirement for okular to be increased at this point

I'm not very familiar with cmake. That about creating a separate patch with the placeholder text and the bottom margin improvement and wait until Okular depends on 5.56 to land the rest (the clear button)?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18658

To: ognarb, #okular, ngraham
Cc: aacid, ngraham, okular-devel, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190301/c13cf268/attachment.html>


More information about the Okular-devel mailing list