D22064: General improvements to stamp annotation

Simone Gaiarin noreply at phabricator.kde.org
Tue Jun 25 19:08:44 BST 2019


simgunz marked 2 inline comments as done.
simgunz added a comment.


  Added the enum, much better now.
  
  @yurchor Great.

INLINE COMMENTS

> ngraham wrote in annotationwidgets.cpp:153
> Are you sure the list of file formats should be localized?

I have copied the code from KIconLoader. I guess that "Icon Files" can be translated. Any suggestion to improve it?

https://api.kde.org/frameworks/kiconthemes/html/kicondialog_8cpp_source.html#l00605

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22064

To: simgunz, #okular
Cc: yurchor, ngraham, okular-devel, fbampaloukas, joaonetto, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190625/3a8f7c13/attachment.html>


More information about the Okular-devel mailing list