D21281: [WIP] Write Documentation for Okular::Part

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> davidhurka wrote in part.h:120
> openUrl() is the function which is usually used by Parts to open something. Someone (me) who wants to understand how documents are opened will want to know what will happen to a call to this function.
> 
> It doesn’t need do be documentation of this function, just describing what will happen to the usual call is enough.
> 
> In the documentation of this function, I consider the following approiate:
> To open a document, the parent application should call openDocument(*) instead of openUrl(). @see openDocument(const QString &url)

the thing is, that's not true, calling openUrl is fine, it's what the okular shell does, no?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21281

To: davidhurka, #okular
Cc: ognarb, jucato, aacid, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190622/3d35db66/attachment.html>