D21734: [WIP] Improve class documentation for PageView and PageViewItem

[David Hurka]

davidhurka marked 6 inline comments as done.
davidhurka added inline comments.

INLINE COMMENTS

> aacid wrote in pageview.h:56
> i kind of know how this works, and i don't understand what "shown pages" is supposed to mean.

Made the item “Content area” more general, to explain its purpose not before the item “Viewport area”.

> aacid wrote in pageview.h:104
> what does "can modify the viewport" mean for you?

Didn’t make sense. fitPageWidth() relayouts the pages, so mentioning that instead.

> aacid wrote in pageview.h:144
> what do you mean by uncropped geometry?

That’s a coordinate system of PageViewItem. Uncropped geometry is now explained in the Detailed Description of PageViewItem.

Do you think this is unclear, or didn’t you read so far yet?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21734

To: davidhurka, #okular
Cc: aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190612/272699a9/attachment-0001.html>