D10859: Improve layout of annotation configuration dialogs

Shubham noreply at phabricator.kde.org
Mon Jun 10 17:54:58 BST 2019


shubham added inline comments.

INLINE COMMENTS

> annotationwidgets.cpp:818
> +    QWidget * widget = (QWidget*)formlayout->parent();
> +
> +    addColorButton( widget, formlayout );

Why not qobject_cast?

REPOSITORY
  R223 Okular

BRANCH
  fix-annot-config-dialog

REVISION DETAIL
  https://phabricator.kde.org/D10859

To: simgunz, #okular, #vdg, ngraham
Cc: shubham, davidhurka, aacid, okular-devel, knambiar, ngraham, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190610/88df14fd/attachment-0001.html>


More information about the Okular-devel mailing list