D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

Nathaniel Graham noreply at phabricator.kde.org
Thu Jun 6 20:27:05 BST 2019


ngraham created this revision.
ngraham added reviewers: Okular, VDG.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  D21624 <https://phabricator.kde.org/D21624> re-arranged the ordering of the selection tools in the toolbar menu. However
  this made it inconsistent with the order in the menu, and now their keyboard
  shortcuts no longer nicely increase.
  
  This patch fixes that. Note that it does involve and necessitate a shortcut switch:
  Text Selection is now [Ctrl] + [3], and Area Selection is now [Ctrl] + [4].

TEST PLAN
  rm `~/.config/okularpartrc`
  
  In toolbar button: F6874944: In pop-up button.png <https://phabricator.kde.org/F6874944>
  
  In Menu: F6874945: In menu.png <https://phabricator.kde.org/F6874945>

REPOSITORY
  R223 Okular

BRANCH
  re-arrange-shortcuts-and-menu-items-accordingly (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21635

AFFECTED FILES
  part.rc
  ui/pageview.cpp

To: ngraham, #okular, #vdg
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190606/b4d9d21d/attachment-0001.html>


More information about the Okular-devel mailing list