D10859: Improve layout of annotation configuration dialogs

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> simgunz wrote in dlgannotationsbase.ui:55
> Yes.
> 
> Both Author and Add had 'a' as accelerator. This was actually working. Pressing 'a' twice switch between the two.
> 
> Nonetheless I changed it to make the accelerators unique.
> 
> Initially I set 'u' as accelerator for Author but this was conflicting with 'Move Up' and the accelerator of author was automatically changed to 't' once running Okular. (not sure why this did not happen also for 'a').
> 
> Then I noticed that not setting the accelerator let Qt set one automatically, so I decided to not set it. Mainly because I though that it make sense to set it only if it has a logical sense like 'u' for Move Up or 'd' for Move Down, but given that 't' is a random letter of author I decided to let it be automatic.
> 
> Maybe it is better to set one explicitly?

It's not Qt. It's kxmlgui that does the autoaccelerator magic. In principle it's always better to set it manually, this way translators know there's an accelrator and can try to set one that makes sense themselves and not leave it to "randomness" of the autoaccelerator magic.

> annotationwidgets.cpp:460
> +        formlayout->addRow( i18n( "Line end:" ), m_endStyleCombo);
> +        formlayout->labelForField( m_startStyleCombo )->setToolTip( i18n("Only for PDF documents") );
> +        formlayout->labelForField( m_endStyleCombo )->setToolTip( i18n("Only for PDF documents") );

you're going to have conflicts, AFAICS this "only for PDF documents" is gone.

REPOSITORY
  R223 Okular

BRANCH
  fix-annot-config-dialog

REVISION DETAIL
  https://phabricator.kde.org/D10859

To: simgunz, #okular, #vdg, ngraham
Cc: davidhurka, aacid, okular-devel, knambiar, ngraham, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190602/fb0265db/attachment-0001.html>