D21271: [WIP] Improve documentation of TextEntity stuff

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> davidhurka wrote in textpage.cpp:1880
> Looks like I messed up my comments.
> 
> > This is some interesting information, which should be documented more visible. Is the information still true?
> 
> belongs only to line 1880:
> 
>   // m_page->width() and m_page->height() are in pixels at
>   //100% zoom level, and thus depend on display DPI. 
> 
> 
> 
> ---
> 
> (Information from line 1880) Should be documented because any Generator has to return the page size at some time. When I was reading about Generator implementation, I wondered what this size should be, and how it is related to the pixmap size. Should I think in 1px/pt? 1px/mm? A completely different unit?
> 
> This (line 1880) is not directly about the Generator, but it might be interesting what will be considered “default size” after the Generator returned the page size.

pagesSizeMetric defines what pagesize means for your generator.

> davidhurka wrote in textpage_p.h:32
> Need this to document the following function prototypes, would not compile otherwise.

Why are there new functions in an "improve documentation" merge request?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21271

To: davidhurka, #okular
Cc: aacid, yurchor, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190602/761c0529/attachment.html>