D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”

[David Hurka]

davidhurka added a comment.


  In D21755#483631 <https://phabricator.kde.org/D21755#483631>, @simgunz wrote:
  
  > What I am probably not understanding is. Is `ToggleActionMenu` meant to be a general component that you want to use in other parts of KDE? Or is it just meant for Okular?
  
  
  Whoa, didn’t answer yet. I think it makes sense to make classes universally useful, instead of fitting them exactly to a single use case. That allows code changes / fixes in the future, while relying on the universally designed classes. The result is that ToggleActionMenu could be used anywhere in KDE. But it is just meant for Okular so far.
  
  > If it is only used in Okular, where do you plan to use it besides than for the mouse actions?
  
  So far, only for color modes: D21195 <https://phabricator.kde.org/D21195>.
  
  > What are the other modes in which it could work, besides the one presented in D21971 <https://phabricator.kde.org/D21971> i.e. as a replacement of ToolAction (basically a cleaner implementation of it).
  
  None so far, except the “default mode” like in D21195 <https://phabricator.kde.org/D21195>.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21755

To: davidhurka, #okular
Cc: simgunz, aacid, #vdg, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190728/7da8ebe5/attachment-0001.html>