D22064: General improvements to stamp annotation

[Albert Astals Cid]

aacid added a comment.


  Small code improvements that can be ignored if you want.
  
  The main concern i have is that we're improving a broken feature, stamps are not saved correctly into the pdf files (because of poppler) so I'm a bit unconvinced of making it easier to select random files since that'll create more broken PDF files out there.
  
  On the other hand this isn't really PDF specific, so i guess it could go in?
  
  What do others think?

INLINE COMMENTS

> annotationwidgets.cpp:45
>  {
> -    QHBoxLayout * mainlay = new QHBoxLayout( this );
> +    m_previewPosition = position;
> +    QVBoxLayout * mainlay = new QVBoxLayout( this );

move this up to the initializer list, i.e.

, m_previewPosition( position )

after QWidget( parent )

> annotationwidgets.cpp:53
> +    toplay->addWidget( m_comboItems );
> +    m_stampPushButton = new QPushButton(QIcon::fromTheme( "document-open" ), "", this );
> +    m_stampPushButton->setVisible( false );

"" -> QString()

> annotationwidgets.cpp:77
>      connect( m_comboItems, &QComboBox::editTextChanged, this, &PixmapPreviewSelector::iconComboChanged );
> +    connect( m_stampPushButton, SIGNAL(clicked()), this, SLOT(selectCustomStamp()) );
>  }

Any reason not to use the "new" connect syntax based on function pointers?

REPOSITORY
  R223 Okular

BRANCH
  improve-stamp-annotation

REVISION DETAIL
  https://phabricator.kde.org/D22064

To: simgunz, #okular, ngraham
Cc: aacid, yurchor, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190721/3e9d36ea/attachment-0001.html>