D15347: Modify CloseDialogHelper in parttest

Oliver Sander noreply at phabricator.kde.org
Tue Jul 16 11:50:31 BST 2019


sander added inline comments.

INLINE COMMENTS

> tobiasdeiminger wrote in parttest.cpp:65
> Don't worry, guess we can simply discard D15347 <https://phabricator.kde.org/D15347> in favor of Olivers change in MR9 <https://invent.kde.org/kde/okular/merge_requests/9/diffs?commit_id=535fc0bb6c9b6b78ab6a952b8a076a5569332427> plus MR13 <https://invent.kde.org/kde/okular/merge_requests/13>.

As MR9 <https://invent.kde.org/kde/okular/merge_requests/9/diffs?commit_id=535fc0bb6c9b6b78ab6a952b8a076a5569332427> may not be merged for quite a while, maybe you want to cherry-pick the relevant parts?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15347

To: tobiasdeiminger
Cc: sander, aacid, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190716/2357e079/attachment.html>


More information about the Okular-devel mailing list