D18719: [WIP]Create context menu entry to rotate individual pages

[Albert Astals Cid]

aacid added a comment.


  In D18719#414068 <https://phabricator.kde.org/D18719#414068>, @shubham wrote:
  
  > How do I resolve this?
  
  
  Don't use the private class, what made you think you can use the private class? it's *private* so obviously it's non usable (unless you know what you're doing and you have reasons for it).
  
  I already told you on IRC how to fix it a long time ago, if you need the functionality, just make it accessible in Page.
  
  By the way does this mean you haven't tested this code at all to see if it actually does anything at all?

INLINE COMMENTS

> page.h:397
> -
> -    private:
>          PagePrivate* d;

This change is totally unacceptable.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18719

To: shubham, aacid, ngraham
Cc: okular-devel, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190217/0001db27/attachment-0001.html>