D18637: Update some files to QQC2 and fix minor bug

Nathaniel Graham noreply at phabricator.kde.org
Fri Feb 1 22:31:14 GMT 2019


ngraham added inline comments.

INLINE COMMENTS

> ngraham wrote in ThumbnailsBase.qml:21
> 1. Please only bump to 2.0, not 2.5 (see above comment for the reason)
> 2. Does this actually work? Every time I've ported anything with a ScrollView from QQC1 to QQC2, the ScrollView part has needed extensive work. Can you make sure all functionality works--especially anything related to the scroll view? E.g. does it actually become scrollable if you resize the window to be very small?

I meant, this can go up 2.0, just not 2.5.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18637

To: ognarb, #okular, ngraham
Cc: ngraham, nicolasfella, okular-devel, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190201/86344e06/attachment.html>


More information about the Okular-devel mailing list