D20760: Okular Annotation: add support for line ending style for Straight Line tool

Rajeesh K Nambiar noreply at phabricator.kde.org
Tue Apr 23 07:23:38 BST 2019


knambiar created this revision.
knambiar added a reviewer: Okular.
knambiar added a project: Okular.
Herald added a subscriber: okular-devel.
knambiar requested review of this revision.

REVISION SUMMARY
  Poppler and Okular already have support for specifying Line End style (`TermStyle`) for the Straight Line tool. Expose the functionality in configuration and hook up the correct slots.

TEST PLAN
  1. Open a PDF in Okular
  2. Enable Review
  3. Right click on Review toolbar and Configure annotations
  4. Create (or edit existing) Straight Line tool
  5. Set the ‘Line End’ option on Style and Apply
  6. Use the Straight Line tool to draw a line and check the line ending style.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D20760

AFFECTED FILES
  conf/editannottooldialog.cpp
  ui/annotationwidgets.cpp
  ui/annotationwidgets.h
  ui/pageviewannotator.cpp

To: knambiar, #okular
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190423/4628164d/attachment.html>


More information about the Okular-devel mailing list