D19717: Search function fails to find phrases split over two lines

[Albert Astals Cid]

aacid added a comment.


  There's a downside to this is that now if you actually put a newline character in the search it will fail where previously it worked.
  
  On the other hand typing an actual newline character is kind of hard (i had to copy it from a newline in kate) so maybe we can just accept that noone really knew how to do that :D
  
  Opinions?

INLINE COMMENTS

> textpage.cpp:865
>          const TinyTextEntity* curEntity = *it;
> -        const QString& str = curEntity->text();
> -        int len = stringLengthAdaptedWithHyphen(str, it, m_words.constEnd());
> +        const QString& strNotUsed = curEntity->text();
> +        int len = stringLengthAdaptedWithHyphen(strNotUsed, it, m_words.constEnd());

strNotUsed seems like a weird variable name given you actually use it the two following names.

Would something like origStr or something make more sense?

> textpage.cpp:866
> +        const QString& strNotUsed = curEntity->text();
> +        int len = stringLengthAdaptedWithHyphen(strNotUsed, it, m_words.constEnd());
> +        const QString str = QString(strNotUsed).replace('\n', ' ');

given that you're modifying this line, make len const :)

Also are you totally sure this needs to be over strNotUsed and not str? Hmmm i guess it works both ways since str is the same length as strNotUsed

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D19717

To: joaonetto, #okular
Cc: aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190421/5972f715/attachment-0001.html>