[Okular-devel] Review Request 117555: Modify how page size label is shown on the bottom bar

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117555/#review55784
-----------------------------------------------------------

Ship it!


The observed behavior follows the description: balanced resize when the pages have the same size (the bottom-right pane is empty); resize with more priority for the (now squeezed) label with the size when the pages have different sizes.

- Luigi Toscano


On April 14, 2014, 12:45 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117555/
> -----------------------------------------------------------
> 
> (Updated April 14, 2014, 12:45 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 333349
>     http://bugs.kde.org/show_bug.cgi?id=333349
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> See "Testing done", do you think that the new behaviour is ok?
> 
> 
> Diffs
> -----
> 
>   part.cpp 9a9979e 
>   ui/pagesizelabel.h d317fd6 
>   ui/pagesizelabel.cpp aa4a043 
> 
> Diff: https://git.reviewboard.kde.org/r/117555/diff/
> 
> 
> Testing
> -------
> 
> Opened a file with all pages with same size and behaves exactly like Okular does
> Opened a file with pages with different sizes and behaves like Okular does until it stops fiting. In that moment the page bar is not centered anymore to let the text still fit and once the text doesn't fit anymore it starts getting ellided.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20140414/25dcfb07/attachment.html>