[Okular-devel] [Bug 225171] New: [PATCH] return focus to document after closing find bar with close button

Will Stephenson wstephenson at kde.org
Mon Feb 1 18:42:23 CET 2010


https://bugs.kde.org/show_bug.cgi?id=225171

           Summary: [PATCH] return focus to document after closing find
                    bar with close button
           Product: okular
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: unspecified
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: okular-devel at kde.org
        ReportedBy: wstephenson at kde.org


Version:            (using Devel)
Installed from:    Compiled sources

There are two different close paths for closing the find bar via a QAction, and
via the button embedded in the bar.  The action variant restores focus to the
document, but the button does not because it just calls QWidget::close()
internally to the bar.  This patch makes the bar request that it is hidden when
the button is clicked, using the same controller logic in the part, which can
then set focus on the document  

This has the effect of also preventing the bar closing if maybeClose() returns
false during a running search, which is the same way the action is handled.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Okular-devel mailing list