<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112134/">http://git.reviewboard.kde.org/r/112134/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 72709fddb61fcbcb404c25c29a01d46be3010810 by Simeon Bird to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 17th, 2013, 5:45 p.m. UTC, Simeon Bird wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Vishesh Handa.</div>
<div>By Simeon Bird.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2013, 5:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests: robustify the sandbox
Running the nepomuk tests always timed out for me. I found that this was
because the nepomukserver was failing to start. There are two problems
here:
1) if the sandbox fails to start, it should just fail, not
timeout.
2) nepomukserver should not fail to start.
This patch fixes 1) by adding return value checking to the sandbox
script; if kdeinit4 & friends fail to start the test fails instantly
2) turned out to be because the nepomukserver could not
connect to the (local) X server. To fix this, I changed the script to be
started through xvfb-run, which starts a virtual X server for it to
connect to.
Finally, start the nepomukserver we just built, rather than the
installed one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only impacts tests. Makes them not timeout for me</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/lib/tools/runNepomukTest.sh.in <span style="color: grey">(2eac3659043e47ebdaa8555061e6a8bbbea98511)</span></li>
<li>autotests/lib/tools/reallyRunNepomukTest.sh.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/lib/tools/nepomuk-sandbox-end.sh.in <span style="color: grey">(e331cb04cce444ab582de9f3f731821792b116f3)</span></li>
<li>autotests/lib/tools/nepomuk-sandbox-begin.sh.in <span style="color: grey">(1517dc99cd7c4247eb4e328100a4d3100979e563)</span></li>
<li>autotests/lib/tools/CMakeLists.txt <span style="color: grey">(2e249628cbe161a059887dc231184aa82e1bc6a4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112134/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>