<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112134/">http://git.reviewboard.kde.org/r/112134/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2013, 2:31 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Most of the changes are good, however I'm not sure this would work. You haven't modified the NepomukTestLibMacros.cmake.in file. It still calls runNepomukTest.sh, instead of running reallyRunNepomukTest.sh
Btw, this library should probably be exported so that other people can use it? Do you want to clean it up and actually install it?</pre>
</blockquote>
<p>On August 19th, 2013, 4:36 p.m. UTC, <b>Simeon Bird</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is ok - NepomukTestLibMacros calls runNepomukTest.sh, whose sole purpose is now to do xvfb-run reallyRunNepomukTest.sh and sleep after that file is done so as to let the X server shut down.
What sort of cleanup export and install did you have in mind? I hadn't really thought beyond just getting make test to work for me, to be honest.</pre>
</blockquote>
<p>On August 20th, 2013, 9:30 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah right. I didn't notice that. Could you elaborate on why one needs an xserver for the Nepomuk tests? Is it just cause we're running kdeinit and all? Also, I'm slightly worries that everyone might not have xvfb-run. I certainly do not.
I'm not sure about what cleanup I had in mind. Maybe an API review of TestBase?
Btw, should this really be going in KDE/4.11?</pre>
</blockquote>
<p>On August 22nd, 2013, 2:25 a.m. UTC, <b>Simeon Bird</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's just because of kdeinit and all. If xvfb-run isn't found, it should just call bash reallyRunNepomukTest.sh. btw, do the tests work for you without xvfb-run? For me I kept getting timeouts on the ResourceTest because kdeinit failed, which was because of some sort of xauth error. </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yup. The tests work for me. They always have.</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On August 17th, 2013, 5:45 p.m. UTC, Simeon Bird wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Vishesh Handa.</div>
<div>By Simeon Bird.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2013, 5:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests: robustify the sandbox
Running the nepomuk tests always timed out for me. I found that this was
because the nepomukserver was failing to start. There are two problems
here:
1) if the sandbox fails to start, it should just fail, not
timeout.
2) nepomukserver should not fail to start.
This patch fixes 1) by adding return value checking to the sandbox
script; if kdeinit4 & friends fail to start the test fails instantly
2) turned out to be because the nepomukserver could not
connect to the (local) X server. To fix this, I changed the script to be
started through xvfb-run, which starts a virtual X server for it to
connect to.
Finally, start the nepomukserver we just built, rather than the
installed one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only impacts tests. Makes them not timeout for me</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/lib/tools/runNepomukTest.sh.in <span style="color: grey">(2eac3659043e47ebdaa8555061e6a8bbbea98511)</span></li>
<li>autotests/lib/tools/reallyRunNepomukTest.sh.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/lib/tools/nepomuk-sandbox-end.sh.in <span style="color: grey">(e331cb04cce444ab582de9f3f731821792b116f3)</span></li>
<li>autotests/lib/tools/nepomuk-sandbox-begin.sh.in <span style="color: grey">(1517dc99cd7c4247eb4e328100a4d3100979e563)</span></li>
<li>autotests/lib/tools/CMakeLists.txt <span style="color: grey">(2e249628cbe161a059887dc231184aa82e1bc6a4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112134/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>