<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110938/">http://git.reviewboard.kde.org/r/110938/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 11th, 2013, 9:59 p.m. UTC, <b>Simeon Bird</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should something similar be done for Nepomuk2::ResourceData::removeProperty as well?</pre>
</blockquote>
<p>On July 31st, 2013, 2:09 p.m. UTC, <b>Simeon Bird</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ping?</pre>
</blockquote>
<p>On August 7th, 2013, 7:30 a.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for reminding me.
I was just taking a look at this patch again, and are you sure it's thread safe? I notice that the resource manager is being locked before accessing any of its members, but in this case we're just accessing the model which has a mutex inside it. So it should be safe, right?
I don't want to commit something right before 4.12 release that causes a lot of crashes.
Also added the same code to removeProperty</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I *think* it is thread-safe, because the only part of the rm we are accessing is the model, which is only set once on initialization, which is guaranteed to happen before the storage service is advertised.
But now I have another worry: what happens if d->overrideModel is set? Can m_model be null in that case?
(is it ever set? I forget what it is for right now...)
Also I totally agree about being safe just before the release - I think its thread safe, but I wouldn't bet my house on it.
How about delaying the commit until just after the 4.11 release, so it has a month of testing before finding its way into 4.11.1?</pre>
<br />
<p>- Simeon</p>
<br />
<p>On June 10th, 2013, 3:44 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Simeon Bird.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated June 10, 2013, 3:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> ResourceData: Do not send the dbus message unless the mainmodel is valid
This way we avoid all those thousands of debug messages of
org.kde.nepomuk.DataManagement not existing because Nepomuk is not
running.
BUG: 269442
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">not really</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libnepomukcore/resource/resourcedata.cpp <span style="color: grey">(ba3f6f4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110938/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>