<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110767/">http://git.reviewboard.kde.org/r/110767/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice!
Could you also add these ape files to Nepomuk2::SimpleIndexingJob::typesForMimeType(QString)? (nepomuk-core/services/fileindexer/indexer/simpleindexingjob.cpp). That way ape files will be counted as Audio files and shown after the first phase indexing as well.
Also, could you please commit this to master and not 4.10. The KDE/4.10 branch is in a messed up state. I rather not touch it.</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On June 1st, 2013, 2:40 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Vishesh Handa.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated June 1, 2013, 2:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some people have them, so why not index them ;-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nepomukshow Facedancers.ape
<nepomuk:/res/eb857393-5cae-4a14-8d50-5b455934c538>
rdf:type nmm:MusicPiece
rdf:type nfo:Audio
rdf:type nfo:FileDataObject
rdf:type nie:InformationElement
nao:created 2013-06-01T14:32:21.091Z
nao:lastModified 2013-06-01T14:32:21.614Z
nie:url file:///home/hrvoje/Facedancers.ape
nie:mimeType audio/x-ape
nie:title Facedancers
nie:lastModified 2013-06-01T14:31:19Z
nie:created 2013-06-01T14:31:19Z
nfo:averageBitrate 6.7700000000e+05
nfo:sampleRate 4.4100000000e+04
nfo:fileSize 204670665
nfo:fileName Facedancers.ape
nfo:channels 2
nfo:duration 2416
nmm:performer nepomuk:/res/08d5211e-85ae-472e-b29b-9b3038a08288
nmm:musicAlbum nepomuk:/res/e9dde4e6-ae72-4ede-8d9d-c38106ea1470
nmm:releaseDate 1972-01-01T00:00:00Z
kext:indexingLevel 2
Somehow nepomukshow didn't catch performer and album, but it's visible in the widget/tooltip</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/fileindexer/indexer/taglibextractor.cpp <span style="color: grey">(941cf74)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110767/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>