<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110317/">http://git.reviewboard.kde.org/r/110317/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 61409470905179289ae72abf98869fe3571f9649 by Vishesh Handa to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 5th, 2013, 11:26 a.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Àlex Fiestas and Simeon Bird.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated May 5, 2013, 11:26 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> kinotify: Optimize the filterWatch process
The FilterWatch is used to to not add watches to everything.
Specifically we do not add watches to names in the exclude list. Also
we only monitor for creation and modification events in the include
folders.
FileIndexerConfig::shouldFileBeIndexed and shouldFolderBeIndexed have a
lot of duplicate code internally. They both use the expensive RegExp
cache.
It's better if we only use the RegExp cache once.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's faster</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/fileindexer/fileindexerconfig.h <span style="color: grey">(9d2d890)</span></li>
<li>services/fileindexer/fileindexerconfig.cpp <span style="color: grey">(b09c915)</span></li>
<li>services/filewatch/nepomukfilewatch.cpp <span style="color: grey">(fbbf3db)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110317/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>