<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109676/">http://git.reviewboard.kde.org/r/109676/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 25th, 2013, 11:57 a.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm just not sure. Eventually we should move to a version based system, cause that would be more secure. Also the problem that we were having seems more like an installation issue that anything else.
I'm worried about the case where the old ontology might have a never mtime. This can happen in my case when I'm running master full time and then I decide to update my distro KDE version. The ontology files installed by nepomuk-core (master) would then get outdated by the nepomuk-core 4.10.2 release, even though my XDG path has been set to let nepomuk-core (master) take precedence over nepomuk-core (distro)</pre>
</blockquote>
<p>On March 25th, 2013, 12:08 p.m. UTC, <b>Jörg Ehrichs</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's what I was asking about on IRC the other night.
I'll have another patch, that checks installed version of any ontology against the version set in the .ontology file.
Usually the mtime of this file was checked instead.
We just need to make sure, the version number there is always updated correctly than.
Because there is a second versions number in the .trig file, together with additional info like "is it upgrade able" etc.
But parsing this info might be more complicated.
What do you think?</pre>
</blockquote>
<p>On March 25th, 2013, 1:41 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah. The question is - should we change this at all? Or should be just continue with the current version? Most people shouldn't have more than 1 version of the ontologies installed.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ping?
I think this can be discarded? We decided that having 2 versions of the ontologies is something that most users just wouldn't have.</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On March 23rd, 2013, 6:31 p.m. UTC, Jörg Ehrichs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Vishesh Handa.</div>
<div>By Jörg Ehrichs.</div>
<p style="color: grey;"><i>Updated March 23, 2013, 6:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Load ontologies from different locations and update alwys to the newest
This removes KStandardDirs::NoDuplicates from the ontology loader.
So if the same ontology is installed twice to teh system both will be
picked up. If the second ontology is newser (timestamp) it will
override the first one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/storage/ontologyloader.cpp <span style="color: grey">(80fe686b213b930c88cf363bf4fd47cabc9b2076)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109676/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>