<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109053/">http://git.reviewboard.kde.org/r/109053/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 14245a39fbe4623a5b637995ccb58d2f523aa5e2 by Vishesh Handa to branch master.</pre>
 <br />









<p>- Commit</p>


<br />
<p>On February 20th, 2013, 9:20 a.m. UTC, Vishesh Handa wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Nepomuk.</div>
<div>By Vishesh Handa.</div>


<p style="color: grey;"><i>Updated Feb. 20, 2013, 9:20 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">    Not just the basic types.
    
    This is done by creating a list of all the types using the
    ClassAndPropertyTree.
    
    Also added a test, and modified existing tests.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The tests pass!</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>services/storage/classandpropertytree.h <span style="color: grey">(76e9eee)</span></li>

 <li>services/storage/classandpropertytree.cpp <span style="color: grey">(b2441a9)</span></li>

 <li>services/storage/datamanagementmodel.cpp <span style="color: grey">(af50d19)</span></li>

 <li>services/storage/resourcemerger.cpp <span style="color: grey">(2f8999a)</span></li>

 <li>services/storage/resourcewatchermanager.h <span style="color: grey">(5d0a26e)</span></li>

 <li>services/storage/resourcewatchermanager.cpp <span style="color: grey">(73d31c3)</span></li>

 <li>services/storage/test/resourcewatchertest.h <span style="color: grey">(2a0c066)</span></li>

 <li>services/storage/test/resourcewatchertest.cpp <span style="color: grey">(0613c40)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109053/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>