<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109018/">http://git.reviewboard.kde.org/r/109018/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 19th, 2013, 9:21 a.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems good apart from the minor issues. Also, I'm not sure if this should be in fileindexer/tests or fileindexer/indexer/tests. It does test the "indexer" part of the "file indexer" (The FileIndexer is just responsible for scheduling the indexing).</pre>
</blockquote>
<p>On February 19th, 2013, 10:13 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you clarify that "I'm not sure if" means "MOVE IT!".</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It means I'm not sure. Okay, "MOVE IT!"</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 19th, 2013, 9:21 a.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109018/diff/1/?file=114372#file114372line60" style="color: black; font-weight: bold; text-decoration: underline;">services/fileindexer/test/indexerextractortests.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">60</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">content</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm a little confused. What is this content variable for and why is it being filled? It's not even being used anywhere.</pre>
</blockquote>
<p>On February 19th, 2013, 10:13 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's used in the line below QTextStream(&content) to get populated.
Then used in one of the QVERIFYs
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Duh. Why didn't I see that!</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On February 18th, 2013, 11:27 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2013, 11:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Start testing the nepomuk file indexer plugins
Tests the generated resource graph for the plain text extractor against a sample file
Obviously this needs extending for all the plugins but I wanted to start with one and agree on the plan/structure before I do any more.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sample output.
********* Start testing of IndexerExtractorTests *********
Config: Using QTest library 4.8.3, Qt 4.8.3
PASS : IndexerExtractorTests::initTestCase()
RESULT : IndexerExtractorTests::benchMarkPlainTextExtractor():
0.042 msecs per iteration (total: 88, iterations: 2048)
PASS : IndexerExtractorTests::benchMarkPlainTextExtractor()
PASS : IndexerExtractorTests::testPlainTextExtractor()
PASS : IndexerExtractorTests::cleanupTestCase()
Totals: 4 passed, 0 failed, 0 skipped
********* Finished testing of IndexerExtractorTests *********</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/fileindexer/test/indexerextractortestsconfig.h.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>services/fileindexer/test/samplefiles/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>services/fileindexer/test/samplefiles/plain_text_file.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>services/fileindexer/test/CMakeLists.txt <span style="color: grey">(49a527f39f6f07afebf8bcd14902b63948c1c33d)</span></li>
<li>services/fileindexer/test/indexerextractortests.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>services/fileindexer/test/indexerextractortests.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109018/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>