<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108985/">http://git.reviewboard.kde.org/r/108985/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Vishesh Handa.</div>
<div>By Simeon Bird.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Filewatch: do not try to watch empty paths.
In slotDeviceMounted, we find the mountPath to watch using
entry->MountPath. However, if the removable device could not be viewed as
a Solid::DeviceType::StorageAccess, mountPath returns QString().
We would then try to watch an empty folder.
In shouldFolderBeWatched we would try to split the empty string,
resulting in an empty list, and take the last component of this list,
leading to an invalid pointer and a crash.
The fix is two-fold:
First, check for empty mountPath in slotDeviceMounted and do not try to
watch it.
Second, check that the split path is not empty in shouldFolderBeWatched
before taking the last component.
BUG: 312423
FIXED-IN: 4.10.1</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compile only</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312423">312423</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/fileindexer/fileindexerconfig.cpp <span style="color: grey">(13a14cfeb8dfe715301d912c78adeb691482c6b0)</span></li>
<li>services/filewatch/nepomukfilewatch.cpp <span style="color: grey">(392f31d88a534cc69245f6d09e73e7838f6ca148)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108985/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>