<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108982/">http://git.reviewboard.kde.org/r/108982/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 16th, 2013, 7:32 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not too sure if 10 threads is enough. We have currently 3 ways of accessing the storage service, each of which spawns a new thread -
* QueryService
* Data Management functions
* Soprano stuff
The QueryService and DataMangagementFunctions are each allocated from a different thread pool of 10 threads. The DataManagement thread pool is never cleaned up (look at datamanagementadpator.cpp). Just these two bring us up to a total of 20 threads. Now there is the fact that each application connects to Nepomuk via the local socket which will also spawn a new thread.
Maybe 30 is a decent number?
For 4.11, we need to combine all these 3 different ways of connecting into 1. I think it would be best if we rolled our own Server/Client code instead of relying on Soprano's which is a little hard to configure according to our needs.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Aha, I didn't realise the QueryService and DataManagement functions were both separate threads.
If you're going to re-work the storage service connections anyway, this is probably not worth the risk, so I'll drop it.
Thanks</pre>
<br />
<p>- Simeon</p>
<br />
<p>On February 16th, 2013, 3:43 p.m. UTC, Simeon Bird wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Vishesh Handa.</div>
<div>By Simeon Bird.</div>
<p style="color: grey;"><i>Updated Feb. 16, 2013, 3:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since soprano no longer creates a separate connection to the database for every thread, we can safely use fewer ServerThreads in virtuoso, saving memory.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Re-indexed some files, less memory is used, nothing seems to break.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/storage/repository.cpp <span style="color: grey">(6a1d004446021b005d8e1d0ab3e70f2cf16de956)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108982/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>