<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108916/">http://git.reviewboard.kde.org/r/108916/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108916/diff/1/?file=113747#file113747line225" style="color: black; font-weight: bold; text-decoration: underline;">services/storage/rcgen/nepomuk-simpleresource-rcgen.py</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">221</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="n">uri</span> <span class="o">==</span> <span class="s">u'http://www.semanticdesktop.org/ontologies/2007/03/22/nco#contributor'</span><span class="p">:</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Instead of these long ifs, which make the code hard to read, make a static dictionary at the top of the file, like ONTOLOGIES = {uri1: name, uri2: name...} then rework the code as
if ONTOLOGIES.get(uri) is None: # handle case when it's not in
name = name.mid(uri.lastIndex of...)
else:
name = ONTOLOGIES[uri]
Benefit, slightly faster lookup as well.</pre>
</div>
<br />
<p>- Luca</p>
<br />
<p>On February 12th, 2013, 12:59 a.m. UTC, Jörg Ehrichs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Sebastian Trueg and Vishesh Handa.</div>
<div>By Jörg Ehrichs.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2013, 12:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To reduce to time necessary for large SimpelResource class generation for
any application that needs more than a few ontologies.
This patch removes most calls to soprano and uses internal dictionary
handling to generate the classes. Thus the class generation for the
Nepomuk-WebMiner is down from ~25min to less than a second.
Instead of asking soprano for the properties/range etc of a class
the output of the Soprano parser is used directly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Class output for Nepomuk-WebMiner is exactly the same just faster.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/storage/rcgen/nepomuk-simpleresource-rcgen.py <span style="color: grey">(d2a4e0c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108916/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>