<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108576/">http://git.reviewboard.kde.org/r/108576/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Vishesh Handa.</div>
<div>By Jörg Ehrichs.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2013, 9:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Removed the timer in metadatamover
* renamed indexingStarted -> matadataUpdateStarted
* renamed indexingStopped -> matadataUpdateStopped
* renamed isIndexing -> isUpdatingMetadata</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The status of the current operation (move/remove metadata) is exported
via dbus to show what is going on.
New dbus methods
* statusMessage - idle message or operation + url
* isUpdatingMetaData - true/false depending if something is happening
New signals
* matadataUpdateStarted
* metadataupdateStopped - only emitted if nothing happend for 5 seconds
* status(int status, string msg) - the integer shows idle/active state
The integer for the status signal was from akonadi_nepomuk feeder
thus we do not need to query if the changes status message also means
the indexer is idle/active (reduce dbus traffic)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* apply patch
* connect to signals via qdbusviewer
* move files around
The status message is shown correctly, idle status switches correctly
No idle status is set if many move/remove operations take place (only after all operations are finished)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/org.kde.nepomuk.FileWatch.xml <span style="color: grey">(e2784a2)</span></li>
<li>services/filewatch/CMakeLists.txt <span style="color: grey">(63307c0)</span></li>
<li>services/filewatch/metadatamover.h <span style="color: grey">(6920849)</span></li>
<li>services/filewatch/metadatamover.cpp <span style="color: grey">(e771f02)</span></li>
<li>services/filewatch/nepomukfilewatch.h <span style="color: grey">(c076601)</span></li>
<li>services/filewatch/nepomukfilewatch.cpp <span style="color: grey">(ea71194)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108576/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>