<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108580/">http://git.reviewboard.kde.org/r/108580/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 25th, 2013, 3:48 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The earlier approach was to sort all the keys and then display then. It just happens that *most*, not all, of the time it was at the bottom since the editable keys started with k (kfileitem#rating, kfileitem#tags, etc).
I like this approach better cause the editable data like the tagging widget is always in the same place. Since the TagWidget is something I expect the users to use a lot it would be nice if its position didn't change. It also makes for better muscle memory this way.
@Frank: What do you think?</pre>
</blockquote>
<p>On January 25th, 2013, 4:05 p.m. UTC, <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First of all, thanks Hrvoje for looking into this issue!
Looks reasoable to me - I agree that it makes sense to have the editable data always in the same place at the bottom.</pre>
</blockquote>
<p>On January 25th, 2013, 4:38 p.m. UTC, <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hey Frank. I'm advocating it be at the top cause then it is always at the same place. With this patch, it will always be at the bottom, and the bottom position could wary based on how many other properties are displayed.
What do you think? Should they be at the bottom or top? I would prefer them being at the top.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, I'm not sure. On the one hand, I thought it makes sense to have the non-editable things (icon, name, etc.) separated from the editable ones, which is achieved by moving the editable properties to the bottom. But OTOH, you're right that the position of the editable things could vary then and might be very low. I'm not sure what the best approach is, I'm not a usability expert :-(</pre>
<br />
<p>- Frank</p>
<br />
<p>On January 25th, 2013, 3:39 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin, Nepomuk, Frank Reininghaus, and Vishesh Handa.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2013, 3:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Provide Editable data at the bottom of the FileMetadataWidget, makes more sense, and that is the same behavior as with the old one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled nepomuk-widgets with the patch, tags/ratings/comments are correctly shown after e.g. album artist/track, etc.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ui/filemetadataprovider.cpp <span style="color: grey">(6f2a235)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108580/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>