<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108305/">http://git.reviewboard.kde.org/r/108305/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 7e0c1a487ad29e30c79dc8b7a17a210cf63c244a by Vishesh Handa to branch KDE/4.10.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 9th, 2013, 6 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin, Nepomuk and Plasma.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2013, 6 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> NepomukRunner: Redirect the 'nepomuk:/res/uuid' urls before opening them
The nepomuksearch kioslave has a special syntax which results in the the
searched term being displayed in "human terms" without the need for
stating the url. The nepomuk kioslave does not have this feature. It,
however, uses the nepomuksearch kioslave internally.
Applications like Dolphin often do not stat a url before displaying it
in the title bar. This results in users seing an ugly "nepomuk - res -
uuid" in the title bar instead of the proper display name as set in the
UDSEntry.
In order to avoid this ugly title bar, we manually redirect all nepomuk
urls to nepomuksearch before they are opened by the runner.
It's a hack, but it works!
BUG: 287259
@Dolphin people: I just thought you might want to know that this is something that will have to be fixed.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yup</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=287259">287259</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp <span style="color: grey">(8075a6b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108305/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>