<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108271/">http://git.reviewboard.kde.org/r/108271/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, and makes the code much simpler and more elegant.
I agree that you don't need m_runnableMutex anymore, because the slots will now be executed in the same thread as the folder, instead of the QRunnable's thread, right? So all methods of Folder live in a single-thread, and the mutex doesn't do anything anymore. So yes, I vote for ditching it.</pre>
<br />
<p>- Simeon</p>
<br />
<p>On January 8th, 2013, 5:36 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, David Faure and Simeon Bird.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2013, 5:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> The SearchRunnable classes used to contain a reference to the Folder and
call certain functions on it. Since the SearchRunnables were in another
thread this required mutexes and still often resulted in deadlocks and
crashes.
The new code uses signals and slots to communicate between the Folder
and the SearchRunnable classes. This is a lot more elegant and easier to
understand.
As far as I see the m_runnableMutex is no longer required. Could someone confirm? Or should I just let it be?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basic functionality testing done. It's a little hard to test the multi-threading part of it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/storage/query/countqueryrunnable.h <span style="color: grey">(3086656)</span></li>
<li>services/storage/query/countqueryrunnable.cpp <span style="color: grey">(14c7917)</span></li>
<li>services/storage/query/folder.h <span style="color: grey">(4baf092)</span></li>
<li>services/storage/query/folder.cpp <span style="color: grey">(0fed8d2)</span></li>
<li>services/storage/query/searchrunnable.h <span style="color: grey">(ca4f596)</span></li>
<li>services/storage/query/searchrunnable.cpp <span style="color: grey">(81a23ac)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108271/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>