<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108190/">http://git.reviewboard.kde.org/r/108190/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No problems that I cans see. Tested the patch and it seems to work.
It's a "Ship It!" from me just don't know which branch it should go to.</pre>
<br />
<p>- Luis</p>
<br />
<p>On January 5th, 2013, 11:27 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Gwenview, Nepomuk and Vishesh Handa.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2013, 11:27 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The change is mostly done by the porting script in http://techbase.kde.org/Projects/Nepomuk/Nepomuk2Port . I just make 2 minimum change manually to make it build and (seemingly) work.
* Remove "#include <nepomuk2/global.h>", since that header is no longer available in nepomuk-core
* Change "find_package(Nepomuk)" to "find_package(NepomukCore)" and related parts
PS: I'm not familiar with the code of neither gwenview nor nepomuk. I come up with this porting patch because gwenview crashes/hangs for me due to kdelibs/nepomuk from time to time ...
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ce64825)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(6627427)</span></li>
<li>app/filtercontroller.cpp <span style="color: grey">(c86ed9f)</span></li>
<li>app/mainwindow.cpp <span style="color: grey">(57f33a1)</span></li>
<li>app/startmainpage.cpp <span style="color: grey">(1141c9e)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(d3f795f)</span></li>
<li>lib/semanticinfo/nepomuksemanticinfobackend.cpp <span style="color: grey">(606214c)</span></li>
<li>tests/auto/CMakeLists.txt <span style="color: grey">(6613f4e)</span></li>
<li>tests/auto/semanticinfobackendtest.cpp <span style="color: grey">(2f670e5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108190/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>