<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108114/">http://git.reviewboard.kde.org/r/108114/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2013, 1:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed all of the issues mentioned in the first review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I ran the migration shell script, made a couple of changes to adjust Thing to Resource and migrated a couple of classes into the utils folder as suggested at http://lists.kde.org/?l=nepomuk&m=135720407314453&w=2</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran nepomukshell, then I saw the Thing class and could expand around and see derived classes, etc. I have very few resources in my display but I guess that is an internal problem and nothing to do with the shell.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1b4dc15)</span></li>
<li>classmodel.h <span style="color: grey">(10b8d03)</span></li>
<li>classmodel.cpp <span style="color: grey">(35fe196)</span></li>
<li>mainwindow.h <span style="color: grey">(f19ea07)</span></li>
<li>mainwindow.cpp <span style="color: grey">(2f3e3bb)</span></li>
<li>newclassdialog.h <span style="color: grey">(dd359c6)</span></li>
<li>newclassdialog.cpp <span style="color: grey">(4916aee)</span></li>
<li>pimomodel.h <span style="color: grey">(91eee95)</span></li>
<li>pimomodel.cpp <span style="color: grey">(46267df)</span></li>
<li>queryeditor.h <span style="color: grey">(e8d815d)</span></li>
<li>queryeditor.cpp <span style="color: grey">(9e9f39c)</span></li>
<li>querymodel.h <span style="color: grey">(698dfee)</span></li>
<li>querymodel.cpp <span style="color: grey">(893d692)</span></li>
<li>resourcebrowserwidget.h <span style="color: grey">(2b34c4f)</span></li>
<li>resourcebrowserwidget.cpp <span style="color: grey">(f3271b9)</span></li>
<li>resourceeditorwidget.h <span style="color: grey">(4f5c36b)</span></li>
<li>resourceeditorwidget.cpp <span style="color: grey">(41e1bdf)</span></li>
<li>resourcepropertymodel.h <span style="color: grey">(ede4b53)</span></li>
<li>resourcepropertymodel.cpp <span style="color: grey">(1d5d62b)</span></li>
<li>resourcequerywidget.h <span style="color: grey">(e914e28)</span></li>
<li>resourcequerywidget.cpp <span style="color: grey">(5172391)</span></li>
<li>resourceview.h <span style="color: grey">(021069d)</span></li>
<li>resourceview.cpp <span style="color: grey">(1987fa3)</span></li>
<li>sparqlCompleter.diff <span style="color: grey">(336b46e)</span></li>
<li>sparqlsyntaxhighlighter.h <span style="color: grey">(a9c93d3)</span></li>
<li>sparqlsyntaxhighlighter.cpp <span style="color: grey">(f4d7774)</span></li>
<li>utils/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>utils/nepomukutils_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>utils/resourcemodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>utils/resourcemodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>utils/simpleresourcemodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>utils/simpleresourcemodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108114/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>