<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108056/">http://git.reviewboard.kde.org/r/108056/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems good. I'm wondering if we should be expanding system links? Or should we just show them and not let them be selected.</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On December 31st, 2012, 9:33 p.m., Gabriel Poesia wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Vishesh Handa.</div>
<div>By Gabriel Poesia.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2012, 9:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When marking folders to be indexed in the KCM ("Indexing" tab, "Customize Folders" button), the user now sees the symbolic links are there, but is not allowed to mark one for indexing, nor its children. Also added a different tooltip to the symlinks, saying that these are not indexed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled, browsed the dialog, the behavior seems consistent.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=287593">287593</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/kcm/folderselectionmodel.h <span style="color: grey">(f8efb44)</span></li>
<li>nepomuk/kcm/folderselectionmodel.cpp <span style="color: grey">(3041089)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108056/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/108056/s/945/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/31/nepomuk_kcm_customize_index_folders_400x100.png" style="border: 1px black solid;" alt="Appearance of the dialog when a symlink is expanded (the tooltip is shown when the mouse is hovering a symlink)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>