<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107553/">http://git.reviewboard.kde.org/r/107553/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 4th, 2012, 7:01 p.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems good enough to me. We will eventually figure out more stuff to add.
Now the main problem is that we will have to wait for about a month to commit this in master (String freeze)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Btw, you can now commit this to the master branch.</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On December 4th, 2012, 6:54 p.m., Gabriel Poesia wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.</div>
<div>By Gabriel Poesia.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2012, 6:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a button to the KCM Nepomuk as suggested in bug #303658. When clicked, the indexer executes the updateAllFolders() method.
The widget was placed in the Nepomuk Repository Details dialog, along with the "Suspend/Resume File Indexing". I'm not sure if it violates
any design principles behind KDE, KCM or Nepomuk (if it should have an icon, for example, like the two other buttons in the dialog).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled, installed, ran kcmshell4 nepomuk. The file indexer was idle.
Clicking the button changed the status message to "Scanning for recent changes in [...]".</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=303658">303658</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/kcm/nepomukconfigwidget.ui <span style="color: grey">(3534213)</span></li>
<li>nepomuk/kcm/nepomukserverkcm.h <span style="color: grey">(c8f9a6b)</span></li>
<li>nepomuk/kcm/nepomukserverkcm.cpp <span style="color: grey">(e27a6a2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107553/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107553/s/870/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/12/04/nepomuk_details_check_new_files_button1_400x100.png" style="border: 1px black solid;" alt="New look of the button" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>