<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107531/">http://git.reviewboard.kde.org/r/107531/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 690e59e13a9ba783f523f6129021fd4d5811642d by Vishesh Handa to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 30th, 2012, 1:23 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Soprano and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Nov. 30, 2012, 1:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> LocalSocketClient: Never delete the ClientConnection
The ClientConnection is not reference counted, and is passed to the the
model and open iterators. Deleting it when has open iterators therefore
leads to crashes.
Instead, the ClientConnection is always persistent. Intead we provide
functions to allow users of the ClientConnection to connect and
disconnect.
Also removed the concept of newConnection() from the ClientConnection.
It no longer spawns a new socket for each thread, so there is no point
of it existing. This new design is a lot simpler.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yup. Everything works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>client/clientconnection.h <span style="color: grey">(bfb3d4d)</span></li>
<li>client/clientconnection.cpp <span style="color: grey">(febd008)</span></li>
<li>client/localsocketclient.cpp <span style="color: grey">(f3579ff)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107531/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>