<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107285/">http://git.reviewboard.kde.org/r/107285/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 436b31deabd46f3ccd8fa0b7d6ac03e1bcac2948 by Simeon Bird to branch KDE/4.9.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 11th, 2012, 4:24 a.m., Simeon Bird wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.</div>
<div>By Simeon Bird.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2012, 4:24 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manually disconnect the socket connection to nepomuk in the resourcemanager when
nepomuk is shut down.
This is needed because the Soprano method isConnected() does not
actually check whether the socket is connected or not,
merely whether it has been connected at some point in the past.
So if we do not disconnect, Nepomuk::MainModel::isValid() will falsely claim
that the connection is ready for data, causing problems
should anything try to use it.
Same as #107283, but for kdelibs nepomuk instead of nepomuk-core nepomuk.
Both are needed to actually fix the bug, even in 4.10, because kFileMetaDataWidget still
depends on nepomuk from kdelibs, and thus dolphin still links to kdelibs nepomuk. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same as 107283</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=295933">295933</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/core/nepomukmainmodel.h <span style="color: grey">(a08ba5c)</span></li>
<li>nepomuk/core/nepomukmainmodel.cpp <span style="color: grey">(3473dbc)</span></li>
<li>nepomuk/core/resourcemanager.cpp <span style="color: grey">(b3a1c80)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107285/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>