<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106748/">http://git.reviewboard.kde.org/r/106748/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From a usability perspective you can't show random popups telling the user to run commands as root.
1) It's putting users in a bad habbit, any app can trigger a popup telling someone to run "sudo rm * -Rf".
2) The vast majority of users aren't in a sys-admin position. Consider all the big KDE deployments to schools, universities and offices. The person using this computer will not have root powers, it's just a pointless helpless error message
3) It looks scary and confusing to a non nerd-user, and looking like a virus to those who know a medium amount.
(from a code POV you're also triggering this every time the limit hits, which assuming the user can't or decides not to change it means this notification will be going off /constantly/. </pre>
<br />
<p>- David</p>
<br />
<p>On October 11th, 2012, 5:54 p.m., Simeon Bird wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, KDE Usability, Vishesh Handa, and Sebastian Trueg.</div>
<div>By Simeon Bird.</div>
<p style="color: grey;"><i>Updated Oct. 11, 2012, 5:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, if we happen to run out of inotify watches in the filewatch service, all we get is a debug message, which is easily lost.
This patch additionally creates a popup notification to warn people they need to raise the limit.
I worried that a popup might be a bit too invasive - I considered also just logging to syslog, but that seemed not invasive enough.
I figured that since metadata can get lost if the watches are not all installed, being fairly invasive is a good idea.
What think you?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> sudo sysctl fs.inotify.max_user_watches=10
> killall nepomukserver && nepomukserver
Yup, there's a notification.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/filewatch/nepomukfilewatch.cpp <span style="color: grey">(83045da)</span></li>
<li>services/filewatch/nepomukfilewatch.notifyrc <span style="color: grey">(bfa88a9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106748/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>