<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106492/">http://git.reviewboard.kde.org/r/106492/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106492/diff/2/?file=86266#file86266line525" style="color: black; font-weight: bold; text-decoration: underline;">services/storage/resourcemerger.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Soprano::Node Nepomuk2::ResourceMerger::resolveMappedNode(const Soprano::Node& node)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">525</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_model</span><span class="o">-></span><span class="n">executeQuery</span><span class="p">(</span> <span class="n">addQuery</span><span class="p">,</span> <span class="n">Soprano</span><span class="o">::</span><span class="n">Query</span><span class="o">::</span><span class="n">QueryLanguageUser</span><span class="p">,</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">"sql"</span><span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why the sql lang, can't you just use sparql without the "sparql" prefix in the query?</pre>
</div>
<br />
<p>- Sebastian</p>
<br />
<p>On September 19th, 2012, 12:08 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2012, 12:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Only convert the node to n3 once. And insert the statements in one go,
thereby avoiding the extra conversion via Soprano::Node::resourceToN3( .. )
Yes, I know, it's micro optimization. But this piece of code is called a lot.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/storage/test/qtest_dms.cpp <span style="color: grey">(ce91843)</span></li>
<li>services/storage/test/resourcewatchertest.cpp <span style="color: grey">(6a3941b)</span></li>
<li>services/storage/test/fakedatamanagementservice.cpp <span style="color: grey">(991a4e7)</span></li>
<li>services/storage/test/qtest_dms.h <span style="color: grey">(5d21e4f)</span></li>
<li>services/storage/test/datamanagementadaptortest.cpp <span style="color: grey">(8ffae7d)</span></li>
<li>services/storage/test/datamanagementmodeltest.cpp <span style="color: grey">(fc97f4b)</span></li>
<li>services/storage/resourcemerger.cpp <span style="color: grey">(1bc87ee)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106492/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>