<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106505/">http://git.reviewboard.kde.org/r/106505/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 19th, 2012, 1:58 p.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you have a more detailed callgrind analysis of the removable media model? Maybe we can optimize it after all. In the end it should only be some hash lookups and string replacement. That is nothing complicated. So if its slow the implementation might be bad.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is just has lookups and string replacements, but they add up over time.
When indexing files storeResources calls 1 query per statement + 2 query per resource (cardinality + types) + graph metadata checks + identification. On average it is very common to have 10-15 queries for even pushing very simple data (mimetype + stat result + rdf:types).
Anyway, this patch seems fairly non-controversial. Doesn't it?</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On September 19th, 2012, 11:53 a.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2012, 11:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> When there are no removeable media connected we shouldn't have to pay
the extremely steep price of the RemoveableMediaModel.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>common/removablemediacache.h <span style="color: grey">(ed11f7d)</span></li>
<li>common/removablemediacache.cpp <span style="color: grey">(fcdec07)</span></li>
<li>services/storage/removablemediamodel.cpp <span style="color: grey">(d2be90a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106505/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>