<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106282/">http://git.reviewboard.kde.org/r/106282/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After testing this out even more I've come to realize that it doesn't to seem to always work -
* Virtuoso inferencing doesn't seem to be working for graph types. I don't get any results for graphs with nrl:DiscardableInstanceBase
* My patch seems to apply the graph filtering for FileQueries as well as normal queries, which is unnecessary.
Not shipping this into 4.9.1. Needs more testing.</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On August 30th, 2012, 9:50 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Aug. 30, 2012, 9:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The additional "?r a [ nao:userVisible "true"^^xsd:boolean ] ." slows down the query a lot because of the massive joins in the generated SQL. It seems better to use graph ?g { .. } ?g a nrl:InstanceBase, which would also filter out the results.
Additionally, the nao:userVisible trick does not work for negation terms and lists out the classes.
I'd like to get this into 4.9.1 if possible. Please review fast.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yup. Manually tested, and it fixes some of my the tests in my query tests (still not pushed, but I can push if anyone is interested) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libnepomukcore/query/query.cpp <span style="color: grey">(21b9aa3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106282/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>